Attention is currently required from: pespin.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email )

Change subject: Remove old empty io_uring
......................................................................


Patch Set 4:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/4e398aaa_15483403?usp=email
 :
PS3, Line 14: The counter is decrements whenever a CQE is received and handled. 
This
> is decremeted
Done


File src/core/osmo_io_uring.c:

https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/77b33a6e_35000b2a?usp=email
 :
PS3, Line 76:   unsigned int in_flight;
> "num_in_transit" woulb be better imho, or at least "num_in_flight" to quickly 
> denote it's counter an […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/bffa0ead_4c64d80e?usp=email
 :
PS3, Line 639:                  ring->in_flight++;
> Sounds like we may want to have a wrapper around io_uring_get_sqe() which 
> increases in_flight if sqe […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id2d2a0400ad442198c684ea0ead4eaeaead4c53d
Gerrit-Change-Number: 40855
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Aug 2025 12:13:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to