Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/6377/1/src/osmo_gsm_tester/log.py File src/osmo_gsm_tester/log.py: Line 278: # Poke into internal to avoid hitting the linecache which will make one or > According to [1], _getframe() can have a depth parameter, which if I unders Thanks for looking up the docs. I assumed it would not be documented at all. I wouldn't want to catch AttributeError. The code will never be executed (and hence likely broken or at least bitrotting). Then PyPy supports sys._getframe() as well (https://bitbucket.org/pypy/pypy/src/fc85b98a24e2a5a30d667659260089db372817f1/pypy/module/sys/__init__.py?at=default&fileviewer=file-view-default#__init__.py-55) ValueError: The unknown/unknown was just because I iterate myself. I think getting a ValueError is good. If somebody passes a bogus offset we can discover this quickly (instead of silencing it). -- To view, visit https://gerrit.osmocom.org/6377 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6bacadcf74d3aa25db1e1f41644f64aa19cf92 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
