Attention is currently required from: daniel, osmith.

pespin has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )

Change subject: Regenerate code with newer asn1c
......................................................................


Patch Set 3:

(1 comment)

File src/constr_CHOICE_print.c:

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/aafd8d16_9a8c38b8?usp=email
 :
PS3, Line 1: /*
> So far there is only the generated files.
Yes, but still it makes sense to have them in well known separate directory.
Furthermore, I think it makes sense to split skeleton and tcp-specific 
generated files in different subdirs, since they serve different purposes and 
are updated in different cases (ASN.1 new version vs asn1c new version).



--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec
Gerrit-Change-Number: 41022
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: daniel <dwillm...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: daniel <dwillm...@sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 10:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: daniel <dwillm...@sysmocom.de>

Reply via email to