Attention is currently required from: osmith, pespin.

daniel has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )

Change subject: Regenerate code with newer asn1c
......................................................................


Patch Set 5:

(2 comments)

This change is ready for review.

Patchset:

PS4:
> Change order in Makefile.am, from  "SUBDIRS = src include" to "SUBDIRS = 
> include src" […]
Seems I missed the generated (TCAP_*.h) headers..


Patchset:

PS5:
This now passes make distcheck.
debian jobs are expected to fail until "debian: initial"
I guess the linter is meaningless for generated code



--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec
Gerrit-Change-Number: 41022
Gerrit-PatchSet: 5
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: daniel <dwillm...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Sep 2025 15:11:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osm...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to