Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email )
Change subject: FR/HR/EFR: centralize TCH UL SID classification ...................................................................... Patch Set 1: (2 comments) File include/osmo-bts/msg_utils.h: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/867dc87a_7b5e3426?usp=email : PS1, Line 25: * Additionally for HRv1 codec, we use a control buffer word to pass IMHO once you improve de comment framing (see first patch); this show go immediatelly above each field being defined (eg. line 43). File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/b933e9d1_c2a84a7a?usp=email : PS1, Line 2349: tch_ul_msg_sid(msg) = sidc; I wonder whether this msg field should be called "hr_sid" instead of "sid". -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3 Gerrit-Change-Number: 41048 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <fal...@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: falconia <fal...@freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
