Attention is currently required from: falconia.

fixeria has posted comments on this change by falconia. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email )

Change subject: FR/HR/EFR: centralize TCH UL SID classification
......................................................................


Patch Set 2:

(1 comment)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/cf2575bf_d2e579d8?usp=email
 :
PS2, Line 2460: This logic can also set
              :          * BFI that wasn't set before
> Is this really the case? I can see `tch_ul_msg_bfi()` being used to check for 
> BFI, but not actually  […]
Indeed, I see the BFI flag being set in the next patch. Marking as resolved.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3
Gerrit-Change-Number: 41048
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: falconia <fal...@freecalypso.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 20:53:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>

Reply via email to