Attention is currently required from: osmith.

pespin has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email )

Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS
......................................................................


Patch Set 1:

(1 comment)

File include/osmocom/gsm/protocol/gsm_04_08.h:

https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/b2b124a5_aae482ee?usp=email
 :
PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the 
network must send
This  kind of approach is usually placed inside the enum to quickly see it's 
related to it:

    enum gsm48_bcap_rrq {
        GSM48_BCAP_RRQ_FR_ONLY  = 1,
        GSM48_BCAP_RRQ_DUAL_HR  = 2,
        GSM48_BCAP_RRQ_DUAL_FR  = 3,
    /* GSM 04.08 Table 10.72: In network to MS direction, the network must send
     * spare bits that are encoded the same as FR_ONLY. */
    #define GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS GSM48_BCAP_RRQ_FR_ONLY
    };



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e
Gerrit-Change-Number: 41056
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Sep 2025 12:24:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to