Attention is currently required from: fixeria, osmith.

pespin has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email )

Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS
......................................................................


Patch Set 2:

(1 comment)

File include/osmocom/gsm/protocol/gsm_04_08.h:

https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/8bb558f1_547292d8?usp=email
 :
PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the 
network must send
> It was rather close to that enum and the same prefix suggests the relation? 
> […]
I really had to use CTRL+F to actually find the enum, so not close enough ;)

Still, when looking at the enum you definetly want to see that field inside. 
I'm not looking outside.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e
Gerrit-Change-Number: 41056
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Sep 2025 13:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to