Attention is currently required from: daniel, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )
Change subject: Regenerate code with newer asn1c ...................................................................... Patch Set 6: (3 comments) Patchset: PS5: > Also, my understanding is that you putting the skeleton files inside > "src/gen", while probably havin […] Done File include/osmocom/tcap/Makefile.am: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/032752ce_14cf3fac?usp=email : PS5, Line 3: TCAP_RLRQ-apdu.h \ > I'd really welcome splitting all these TCAP_* generated headers into a > separate variable (and then i […] Done File include/osmocom/tcap/TCAP_Unidirectional.h: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/670b576a_34d43e83?usp=email : PS5, Line 16: #include <constr_SEQUENCE.h> > All these includes most probably need to be patched during Makefile to be > prefixed"<osmocom/tcap/... […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: daniel <dwillm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Mon, 15 Sep 2025 10:33:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de>
