Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email )

Change subject: [REST] OpenAPI: fix regexp to permit IPv6 addr in EnbId
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File contrib/openapi.yaml:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298/comment/ba6903cf_b02873a5?usp=email
 :
PS1, Line 195:             pattern: '^enb-conn:[0-9a-f:.]+-[0-9]+$'
I'm not a regexp by any means, but apparently matching a n IP address is a bit 
more complex?

https://www.ditig.com/validating-ipv4-and-ipv6-addresses-with-regexp#combined-ipv4-and-ipv6-validation

https://regex101.com/r/tF7zQ1/1



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I112283b140a070924d59935a3bdd6fd63fc8c7ea
Gerrit-Change-Number: 41298
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 05 Nov 2025 09:17:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to