Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email )

Change subject: [REST] OpenAPI: fix regexp to permit IPv6 addr in EnbId
......................................................................


Patch Set 1:

(1 comment)

File contrib/openapi.yaml:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298/comment/b14734d3_ea8a661d?usp=email
 :
PS1, Line 195:             pattern: '^enb-conn:[0-9a-f:.]+-[0-9]+$'
> I'm not a regexp by any means, but apparently matching a n IP address is a 
> bit more complex? […]
Yes, a proper/complete regexp for IPv4v6 would be huge. But we don't really 
need this level of complexity here: we don't care if the address is 100% 
correct. We simply match the prefix and enforce basic data format (`addr-port`) 
for this variant of `EnbId`.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41298?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I112283b140a070924d59935a3bdd6fd63fc8c7ea
Gerrit-Change-Number: 41298
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 05 Nov 2025 09:25:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to