Attention is currently required from: jolly.

pespin has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email )

Change subject: RSSI app: Use correct BSIC for RACH bursts
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1:
Agree with fixeria that "Fixes" really helps understand this commit, please add 
it.


File src/target/firmware/apps/rssi/main.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/41358/comment/44941be1_8d70e9b9?usp=email
 :
PS1, Line 1212:         rach_req->uic = 0xff;
Probably makes sense to add a comment: /* Invalid UIC, so that BSIC is used */



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19
Gerrit-Change-Number: 41358
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Thu, 06 Nov 2025 15:10:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to