Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email )
Change subject: RSSI app: Use correct BSIC for RACH bursts ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/41358/comment/6c54da03_341b6f17?usp=email : PS1, Line 10: does not override the BSIC with a wrong value. > what does "uic" mean here? Done https://gerrit.osmocom.org/c/osmocom-bb/+/41358/comment/a6d21cb5_d6b291cb?usp=email : PS1, Line 12: Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19 > Please add `Fixes: 23d46f003 ("ASCI: Add UIC support to random access > burst")` here. […] Done File src/target/firmware/apps/rssi/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/41358/comment/1a8b544f_5ffe94d4?usp=email : PS1, Line 1212: rach_req->uic = 0xff; > Probably makes sense to add a comment: /* Invalid UIC, so that BSIC is used */ Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19 Gerrit-Change-Number: 41358 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 13:31:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
