Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email )
Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Patch Set 8: (3 comments) File src/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/f3f4af85_d7ade180?usp=email : PS8, Line 13: ss7_as_loadshare_tcap_vty.h \ > tcap_loadshare_vty.{c,h}? […] No, I have static inline functions which no-ops, when the feature is not used. IMHO: this keeps the code cleaner, because it reduces the amount of #ifdef/#endif in the code. File src/ss7_as_loadshare_tcap_vty.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/db119fe6_56cdf730?usp=email : PS8, Line 6: #ifdef WITH_TCAP_LOADSHARING > Drop this, simply only include the header when ifdef > BUILD_WITH_TCAP_LOADSHARING No, I like to have static inlines instead if the feature isn't enabled. File src/ss7_as_loadshare_tcap_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/0f115d86_b02b5366?usp=email : PS8, Line 50: "show cs7 instance <0-15> as tcap-ranges name AS_NAME", > are we using the same ordering in other vty command? looks weird ot have > "as", then "tcap-ranges" an […] @[email protected]? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
