Attention is currently required from: lynxis lazus, pespin.

daniel has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email )

Change subject: Add VTY command to list TCAP ranges for an AS
......................................................................


Patch Set 13:

(4 comments)

File src/Makefile.am:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/3a96f952_e04d5314?usp=email
 :
PS8, Line 13:   ss7_as_loadshare_tcap_vty.h \
> No, I have static inline functions which no-ops, when the feature is not 
> used. […]
Done


File src/ss7_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/d40dc955_48311f6a?usp=email
 :
PS8, Line 42: #include "ss7_as_loadshare_tcap_vty.h"
> ifdef
Done


https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/0e4b9af6_e8d25ed9?usp=email
 :
PS8, Line 1487:         ss7_tcap_vty_init();
> ifdef
Done


File tests/vty/osmo_stp_test.vty:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/a9375cbe_fa633982?usp=email
 :
PS10, Line 21:   show cs7 instance <0-15> as name AS_NAME tcap-ranges tid TID
> This still needs some way to test a different file depending on whether 
> HAVE_TCAP_ROUTING is defined […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf
Gerrit-Change-Number: 41311
Gerrit-PatchSet: 13
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Thu, 27 Nov 2025 16:55:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: daniel <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to