Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email )
Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: > Quick test for whoever. Under bash: […] Hmm, the problem is that debian's "dash" behaves differently. ``` $ dash $ echo -e "\033[1;32mBYE\033[1;0m" -e BYE ``` ``` $ ls -l /bin/sh lrwxrwxrwx 1 root root 4 Mar 31 2024 /bin/sh -> dash ``` In this case I would either recommend using POSIX shell compatible syntax instead with printf: ``` printf "\033[1;32m%s\033[1;0m\n" "BYE" ``` This one works as expected with dash, bash and zsh. Or changing `#!/bin/sh` to `#!/bin/bash`, in addition with the changes you already have in this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 04 Dec 2025 07:12:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]>
