Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email )

Change subject: osmo-release.sh: Fix coloring output under bash
......................................................................


Patch Set 2:

(1 comment)

File osmo-release.sh:

https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/7fc80951_87b986ca?usp=email
 :
PS2, Line 39:   printf "${GREEN}OK:${RESET} $@\n"
> actually this is better ("$@" would expand to multiple additional printf 
> arguments whereas we only h […]
What's wrong with current approach?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc
Gerrit-Change-Number: 41547
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Fri, 05 Dec 2025 10:21:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>

Reply via email to