Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email )
Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/8e639807_1613a3bf?usp=email : PS2, Line 9: counter a 8 bit value > **is** a 8 bit value Done File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/59ba705a_c5fdc37f?usp=email : PS2, Line 112: monotonic timer could be to reproducible on systems > What do you mean here? This comment is confusing... maybe it's better now. https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/866d405b_f06fd7d7?usp=email : PS2, Line 115: UserConfig > This argument has two different names: `Options` in `start_link()` and > `UserConfig` here. […] The other values are mandatory. This one is an optional one. I would like to keep it for this commit. If changes are necessary, this should go into another commit. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 04 Dec 2025 22:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
