Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email )
Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: I'm not following here. 1- You are adding a default value which is basically rand()%256, which defeats the purpose of restart_counter. 2- AFAIU you can configure the restart_counter from config file, but then that means everytime osmo-epdg restarts a user needs to manually edit the file and start osmo-epdg again? I don't see how is this improving the situation over last commit, actually it's worse afaiu. File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/3dc38dfb_1c6e7346?usp=email : PS5, Line 111: % Use system_time in order to ensure a fresh system wouldn't re-use always the same restart_counter AFAIU this is not true, you have 1/256 chance to get the same restart_counter every time you start osmo-epdg. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Fri, 05 Dec 2025 10:35:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
