Attention is currently required from: laforge.

dexter has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/41713?usp=email )

Change subject: pysim/log: also accept ANSI strings to specify the log message 
colors
......................................................................


Patch Set 2:

(1 comment)

File pySim/log.py:

https://gerrit.osmocom.org/c/pysim/+/41713/comment/8914a10f_dded18f6?usp=email :
PS1, Line 111:                 if type(color) is str:
> I think isinstance(color, str) would be the more appropriate, as the above 
> only matches if it's *exa […]
Thanks for the hint. I haven't had that in mind.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921
Gerrit-Change-Number: 41713
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Fri, 19 Dec 2025 11:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to