Attention is currently required from: fixeria, laforge.

dexter has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/41713?usp=email )

Change subject: pysim/log: also accept ANSI strings to specify the log message 
colors
......................................................................


Patch Set 3:

(1 comment)

File pySim/log.py:

https://gerrit.osmocom.org/c/pysim/+/41713/comment/98801bb5_2bb58a62?usp=email :
PS1, Line 111:                 if type(color) is str:
> I believe Harald's suggestion was to do `isinstance(color, str)` instead of 
> `type(color) is str`, bu […]
I think I missed the line - it worked when I tested it with an ANSI string ;-/



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41713?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I93543e19649064043ae8323f82ecd8c423d1d921
Gerrit-Change-Number: 41713
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 19 Dec 2025 15:26:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to