Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41734?usp=email )
Change subject: esim.saip.FsProfileElement: Add file2pe() for single file conversion ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: I have the feeling that file2pe method might bear a risk to cause inconsistencies. File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/41734/comment/1bfc32fc_48031ac1?usp=email : PS3, Line 636: def file2pe(self, f: File): Maybe replace "f" with "file" to make it more uniform to the add_file method? https://gerrit.osmocom.org/c/pysim/+/41734/comment/8b68b5b9_6ab4f070?usp=email : PS3, Line 638: self.decoded[f.pe_name] = f.to_tuples() There is something I am struggling with. There is already the add_file() method. This method adds files to self.files and does a couple of other things as well. When we now use file2pe to put a file from whatever source into self.decoded. Then the rest of the class members (self.files, etc.) know nothing about the update. For example, the next time we run files2pe, the updated file gets overwritten with the old content. Maybe we need a more elaborated update function, similar to add_file? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7b7f61aae6b7df6946dadf2f78fddf92995603ec Gerrit-Change-Number: 41734 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 22 Dec 2025 16:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
