Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41734?usp=email )
Change subject: esim.saip.FsProfileElement: Add file2pe() for single file conversion ...................................................................... Patch Set 5: Code-Review+2 (3 comments) Patchset: PS5: re-adding the existing +2 before addressing latest feedback File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/41734/comment/232f7996_3416d33c?usp=email : PS3, Line 636: def file2pe(self, f: File): > Maybe replace "f" with "file" to make it more uniform to the add_file method? done. https://gerrit.osmocom.org/c/pysim/+/41734/comment/b78cd03b_18c57aa1?usp=email : PS3, Line 638: self.decoded[f.pe_name] = f.to_tuples() > Ah ok. I see. Its intentional. Then option a is probably the preferred one. > […] I added a related check, i.e. we raise an exception if the passed file is not part of the PE's files dict. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7b7f61aae6b7df6946dadf2f78fddf92995603ec Gerrit-Change-Number: 41734 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 23 Dec 2025 20:00:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: dexter <[email protected]>
