Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email )
Change subject: ms_power_control: Apply defaults during reset ...................................................................... Patch Set 1: (2 comments) File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/78b081f1_ca9e2c32?usp=email : PS1, Line 150: /* XXX: should we use the maximum power level instead of 0 dBm? */ Not critical, but I would prefer to see this comment before the `state->max = ms_pwr_ctl_lvl(...)` since it's related exactly to that line. File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/21658902_2e7f4e1b?usp=email : PS1, Line 2054: XXX: should we use the maximum power level instead of 0 dBm This comment does not belong here anymore. It's related to that line: ``` lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0); // 0 dBm ``` so I suggest removing it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 Gerrit-Change-Number: 41795 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 09 Jan 2026 13:57:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
