Attention is currently required from: fixeria.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email )

Change subject: ms_power_control: Apply defaults during reset
......................................................................


Patch Set 1:

(2 comments)

File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/05499164_4fb9f53b?usp=email
 :
PS1, Line 150:  /* XXX: should we use the maximum power level instead of 0 dBm? 
*/
> Not critical, but I would prefer to see this comment before the `state->max = 
> ms_pwr_ctl_lvl(... […]
Done


File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/b8e59836_8d718612?usp=email
 :
PS1, Line 2054: XXX: should we use the maximum power level instead of 0 dBm
> This comment does not belong here anymore. It's related to that line: […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3
Gerrit-Change-Number: 41795
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 09 Jan 2026 14:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to