Attention is currently required from: Timur Davydov, laforge, neels, pespin.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 21: (11 comments) Patchset: PS21: Marking threads resolved. File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/669d030a_b5f629fe?usp=email : PS16, Line 259: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes" && test "x$emscripten" != "xyes") > Done. I’ve sent a separate patch addressing this, preceding this one. Done File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/2966d55e_79008bdd?usp=email : PS5, Line 285: LOG_TGT_TYPE_WEB, /*!< Web logging */ > Thanks for the clarification. […] Done File src/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/36f0c2da_7d2790fa?usp=email : PS7, Line 49: logging_emscripten.c \ > Thanks for the suggestion, agreed. […] Done File src/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/2bb05309_d8223045?usp=email : PS16, Line 87: if ENABLE_TUN > Agreed, this likely needs an additional fix. This should follow the same […] Done File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/18a02eda_de553728?usp=email : PS7, Line 24: /*! \addtogroup logging > Please make sure you rebase your work on top of current master, I did some > changes to configure. […] Done File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/abb3421d_20be3562?usp=email : PS5, Line 907: #if !defined(__EMSCRIPTEN__) > The conditional compilation here was added by mistake — it's not needed in > this place. […] Done https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/8bbfaf60_4f86e3e6?usp=email : PS5, Line 1038: DEFUN(cfg_log_web, cfg_log_web_cmd, > Thanks — added conditional compilation `#if defined(__EMSCRIPTEN__)` Done https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/6815e7b1_7a87010b?usp=email : PS5, Line 1047: vty_out(vty, "%% Unable to create WEB log for %s", VTY_NEWLINE); > Thanks, fixed Done https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/fa49905b_396c476c?usp=email : PS5, Line 1067: vty_out(vty, "%% Unable to find WEB log target for %s", VTY_NEWLINE); > Thanks, fixed Done File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/582ca768_8110edad?usp=email : PS16, Line 937: #if !defined(__EMSCRIPTEN__) > Agreed. I disabled it only to avoid creating files on the Web side, but since > […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 21 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Mon, 26 Jan 2026 09:00:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
