Attention is currently required from: fixeria, laforge, neels, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )
Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 22: (2 comments) File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/bd6cdc38_1ff8e0e1?usp=email : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__) > I'm delaying review of this patch until the previous one regarding netdev is > solved, because anyway […] I've moved the netdev changes into a separate patch and will address that first. I dropped the Emscripten-specific include logic and instead guard the Linux netlink headers by the libmnl backend, because the only code that needs <linux/if_link.h>/<linux/rtnetlink.h> is under the libmnl-enabled blocks. So when libmnl is disabled, we no longer try to include Linux-only headers on non-Linux targets. When libmnl is enabled, requiring those Linux headers is expected. https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/27e9de57_c1f1ed3f?usp=email : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__) > I'm delaying review of this patch until the previous one regarding netdev is > solved, because anyway […] I've moved the netdev changes into a separate patch and will address that first. I dropped the Emscripten-specific include logic and instead guard the Linux netlink headers by the libmnl backend, because the only code that needs <linux/if_link.h>/<linux/rtnetlink.h> is under the libmnl-enabled blocks. So when libmnl is disabled, we no longer try to include Linux-only headers on non-Linux targets. When libmnl is enabled, requiring those Linux headers is expected. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 22 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 26 Jan 2026 10:09:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
