Attention is currently required from: fixeria, laforge.

dexter has posted comments on this change by laforge. ( 
https://gerrit.osmocom.org/c/pysim/+/37925?usp=email )

Change subject: pySim-trace: pySim.apdu_source.stdin_hex
......................................................................


Patch Set 4: Code-Review+2 Verified+1

(1 comment)

Patchset:

PS4:
I have re-tested this and it seems to work fine. The reason why 
00a40004023f0000 did not generate any output at first was that it is a SELECT 
APDU and since pySim-trace does suppress those by default, no output was 
visible. This lead to some confusion.

With

./pySim-trace.py --no-suppress-select stdin-hex

I get the expected output. As far as I can see, everything looks good to me and 
we could merge this patch now.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33
Gerrit-Change-Number: 37925
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 26 Jan 2026 14:14:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to