Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email )
Change subject: pySim-trace: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File pySim/apdu_source/stdin_hex.py: https://gerrit.osmocom.org/c/pysim/+/37925/comment/781b7925_2851b5fe?usp=email : PS6, Line 36: response = '9000' Maybe one last suggestion: We should check if the input is empty, otherwise '9000' ends up in parse_cmd_bytes and this may produce error messages that may be confusing to the user. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 28 Jan 2026 09:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
