Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email )
Change subject: stream: Fix build with --disable-libsctp ...................................................................... Patch Set 3: (4 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/be35e17d_4a578ecf?usp=email : PS1, Line 7: stream: make SCTP usage conditional on HAVE_LIBSCTP > I think this patch you be named instead: […] Agreed, renamed to "stream: Fix build with --disable-libsctp". File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/c0e3e582_20f494dc?usp=email : PS1, Line 53: #include <osmocom/netif/sctp.h> > You can actually simply move this below inside the ifdef in line 58. Done, moved it inside the `#ifdef HAVE_LIBSCTP` as suggested. File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/5fe214dd_eaffd06a?usp=email : PS1, Line 1273: local_addrcnt = cli->local_addrcnt; > You could do […] Done, refactored as suggested to reduce the `#ifdef HAVE_LIBSCTP` block. File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/06ce6b13_78d6fc45?usp=email : PS1, Line 1050: #ifdef HAVE_LIBSCTP > #ifdef HAVE_LIBSCTP […] Done, refactored as suggested. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65 Gerrit-Change-Number: 41952 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 26 Jan 2026 17:18:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
