Attention is currently required from: Timur Davydov, pespin.

laforge has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email )

Change subject: stream: Fix build with --disable-libsctp
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/24e87422_3f978e4c?usp=email
 :
PS1, Line 53: #include <osmocom/netif/sctp.h>
> Done, moved it inside the `#ifdef HAVE_LIBSCTP` as suggested.
Done


File src/stream_cli.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/960ebc64_ae34fbf2?usp=email
 :
PS1, Line 1273:                         local_addrcnt = cli->local_addrcnt;
> Done, refactored as suggested to reduce the `#ifdef HAVE_LIBSCTP` block.
Done


File src/stream_srv.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/1f12c4f8_f52ff4d3?usp=email
 :
PS1, Line 1050: #ifdef HAVE_LIBSCTP
> Done, refactored as suggested.
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65
Gerrit-Change-Number: 41952
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: Timur Davydov <[email protected]>
Gerrit-Comment-Date: Mon, 26 Jan 2026 18:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: Timur Davydov <[email protected]>

Reply via email to