Attention is currently required from: canghaiwuhen. Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email )
Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 4: (15 comments) File src/sgsn/gprs_sm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/63636a23_7f585a14?usp=email : PS4, Line 214: uint8_t qos_len; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/cb543d06_28a499c5?usp=email : PS4, Line 214: uint8_t qos_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/01b18d85_0e3adcd6?usp=email : PS4, Line 215: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/1c8ced0d_1631ff87?usp=email : PS4, Line 215: code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/c2ed8207_cef06627?usp=email : PS4, Line 215: please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/ea785cf1_70f6457b?usp=email : PS4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos)) code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/a57aee26_717b0277?usp=email : PS4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos)) please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/9eea306f_27a61c7d?usp=email : PS4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos)) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/264430df_a6d61480?usp=email : PS4, Line 217: qos_len = sizeof(default_qos); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/1b7aa66f_20b8e671?usp=email : PS4, Line 217: qos_len = sizeof(default_qos); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/177cc261_fc114c3c?usp=email : PS4, Line 218: else code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/84e8518c_0c76cd3b?usp=email : PS4, Line 218: else please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/fbadf544_3a6f6a32?usp=email : PS4, Line 218: else suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/3acca790_ff2899c7?usp=email : PS4, Line 219: qos_len = pdp->req_qos_len; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/2aea1bf5_8fa0b5e8?usp=email : PS4, Line 219: qos_len = pdp->req_qos_len; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 4 Gerrit-Owner: canghaiwuhen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: canghaiwuhen <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 02:09:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
