Attention is currently required from: canghaiwuhen, pespin. fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email )
Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 6: Code-Review+1 (4 comments) File src/sgsn/gprs_sm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/b1f05aa3_4306a799?usp=email : PS1, Line 210: ANTIGRAVITY PATCH: True Echo. > What does this mean? Done https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/109b0034_71f18df4?usp=email : PS1, Line 219: if (qos_len > sizeof(default_qos)) > ```suggestion […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/bd2ad1ca_c3de232c?usp=email : PS1, Line 340: tp->lv[OSMO_IE_GSM_REQ_QOS].len > ```suggestion […] Done File src/sgsn/gprs_sm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/95358616_721c2ccb?usp=email : PS3, Line 221: msgb_lv_put(msg, qos_len, (uint8_t *)&default_qos); > let's better do: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 6 Gerrit-Owner: canghaiwuhen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: canghaiwuhen <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 06:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
