Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963?usp=email )

Change subject: stp: Handle N-PCSTATE.ind in STP_Tests_TCAP.ttcn
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

File stp/STP_Tests_TCAP.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963/comment/49c759df_0b6fd4d8?usp=email
 :
PS1, Line 142:                  /* All peers are explicitly available, we are 
done */
Maybe log a message here too to be explicit that it didn't run into the timeout 
(which also causes it to claim success)?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963/comment/af37037c_d81b2af2?usp=email
 :
PS1, Line 155:          /* Done, assume PCs for which we didn't receive an 
explicit "unavailable" are actually available. */
Log a warning here when this happens?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie1beb2cd69ce1847f3b3bd9917b42a2acaef57c8
Gerrit-Change-Number: 41963
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 29 Jan 2026 11:23:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to