Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963?usp=email )

Change subject: stp: Handle N-PCSTATE.ind in STP_Tests_TCAP.ttcn
......................................................................


Patch Set 1:

(2 comments)

File stp/STP_Tests_TCAP.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963/comment/b7bd2d6c_16824170?usp=email
 :
PS1, Line 142:                  /* All peers are explicitly available, we are 
done */
> Maybe log a message here too to be explicit that it didn't run into the 
> timeout (which also causes i […]
See line 158. peer_st_list there tells you that information.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963/comment/224a4c93_d42bd28e?usp=email
 :
PS1, Line 155:          /* Done, assume PCs for which we didn't receive an 
explicit "unavailable" are actually available. */
> Log a warning here when this happens?
See line 158. peer_st_list there tells you that information.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie1beb2cd69ce1847f3b3bd9917b42a2acaef57c8
Gerrit-Change-Number: 41963
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Thu, 29 Jan 2026 11:31:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>

Reply via email to