Attention is currently required from: canghaiwuhen. pespin has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email )
Change subject: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. If the PDP is not released after successful attachment, the module will restart, and subsequent TCP connections will fail. ...................................................................... Patch Set 5: Code-Review-1 (5 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/d9e10470_b75e3806?usp=email : PS5, Line 7: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. Missing first line with acceptable length. You are writing the whole description in the first line. File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/d3c84754_616b1cfb?usp=email : PS5, Line 1339: } else { All changes in this file are totally unrelated to those of QoS. Submit a separate patch for individual code review. https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/11c5685c_367d7d8e?usp=email : PS5, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state. These lines are too long, split them. https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/9b0a1e3c_727925de?usp=email : PS5, Line 1344: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi); Line too long. File src/sgsn/gprs_sm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/044b6397_a6aed6de?usp=email : PS5, Line 209: //msgb_lv_put(msg, sizeof(default_qos), (uint8_t *)&default_qos); This line can be removed, since you are replacing it. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c Gerrit-Change-Number: 42050 Gerrit-PatchSet: 5 Gerrit-Owner: canghaiwuhen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: canghaiwuhen <[email protected]> Gerrit-Comment-Date: Wed, 11 Feb 2026 09:57:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
