Attention is currently required from: canghaiwuhen, laforge, pespin. Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email )
Change subject: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. If the PDP is not released after successful attachment, the module will restart, and subsequent TCP connections will fail. ...................................................................... Patch Set 6: (8 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/2dffa20e_9fc7053a?usp=email : PS6, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/7ce81eed_45325a13?usp=email : PS6, Line 1342: * We must clean up the old PDP context on the SGSN side; trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/cf1cacbc_f617daf0?usp=email : PS6, Line 1343: * otherwise, the SGSN will not recreate them, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/46678442_554d897d?usp=email : PS6, Line 1347: LOGMMCTXP(LOGL_NOTICE, ctx, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/0e4aad5f_bad1b9bf?usp=email : PS6, Line 1348: "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/80c4b694_5bf56800?usp=email : PS6, Line 1371: /* [FIX] Known P-TMSI context. Similarly, if the module re-attaches, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/bd43cadc_a05f34d8?usp=email : PS6, Line 1375: LOGMMCTXP(LOGL_NOTICE, ctx, trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/259d5cf4_b9709496?usp=email : PS6, Line 1376: "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c Gerrit-Change-Number: 42050 Gerrit-PatchSet: 6 Gerrit-Owner: canghaiwuhen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: canghaiwuhen <[email protected]> Gerrit-Comment-Date: Wed, 11 Feb 2026 12:45:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
