Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email )

Change subject: rspro_server: fix releasing timed out clients
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File src/server/rspro_server.c:

https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/37bbf8b4_f8a3fae8?usp=email
 :
PS1, Line 926:          osmo_stream_srv_destroy(peer);
osmo_stream_srv_destroy(conn->peer) calls talloc_free(conn->peer), so it 
totally makes sense to do conn->peer here in order to avoid double free.


https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/71677556_b7179cb8?usp=email
 :
PS1, Line 938:
if (conn->fi) {
        osmo_fsm_inst_free(conn->fi);
        conn->fi = NULL;
    }



--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95
Gerrit-Change-Number: 42133
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Tue, 17 Feb 2026 10:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to