Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email )

Change subject: rspro_server: fix releasing timed out clients
......................................................................


Patch Set 1:

(1 comment)

File src/server/rspro_server.c:

https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/33a52291_8cd4f87d?usp=email
 :
PS1, Line 923:  /* this will internally call closed_cb() which will dispatch a 
TCP_DOWN event */
> This is your comment which would set it to NULL
With your proposal you'll end up with a double free of the osmo_stream_srv 
afaict, from the parent talloc_free(conn) at the end of this function, and from 
within osmo_stream_srv_destroy() after closed_cb returns.



--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95
Gerrit-Change-Number: 42133
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Tue, 17 Feb 2026 11:32:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to