Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email )
Change subject: twjit: add underrun extension feature ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/da04aed9_4ff791ce?usp=email : PS1, Line 554: twjit->stats.underruns++; shouldn't "twjit->stats.too_old++;" be increased too here if id == INPUT_TOO_OLD? https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/3ebc85a0_de8b2f1b?usp=email : PS1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit) Some ideas, no need to apply them if you don't want: It may make sense to specify here that this is expected to be called from state TWJIT_STATE_FLOWING. It may even make sense to merge it into osmo_twjit_output(). Or maybe change this function into being only the content of the "if" path, and name it "transition_to_state_underrun()" or "state_underrun_onenter()" or similar. See comment below. https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/b6ae9552_701b6d41?usp=email : PS1, Line 671: if (read_sb_is_empty(twjit)) { if (!read_sb_is_empty(twjit)) { read_sb_thinning(twjit); return pull_from_read_sb(twjit); } if (twjit->config.underrun_ext) transition_to_state_underrun(twjit); else twjit->state = TWJIT_STATE_EMPTY; return NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 Gerrit-Change-Number: 42141 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: falconia <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 10:30:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
