Attention is currently required from: fixeria, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email )
Change subject: twjit: add underrun extension feature ...................................................................... Patch Set 2: (2 comments) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/1019d477_d2aed98e?usp=email : PS1, Line 554: twjit->stats.underruns++; > shouldn't "twjit->stats. […] In the new iteration of my patch, I added a comment explaining while this stats counter should not be incremented in this state. https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/fc7dc15b_d96620fd?usp=email : PS1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit) > Some ideas, no need to apply them if you don't want: […] I added an explanatory comment in the new iteration of my patch - is it good enough? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673 Gerrit-Change-Number: 42141 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 16:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
