Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )
Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/8b9dd9ed_8d2a72db?usp=email : PS1, Line 8: > No. This patch stays exactly like this. Both messages were wrong, and now > they agree with the spec. […] Just to be clear, both messages were just plain wrong, there is no "different" wrong or "different" problems, It absolutely does not matter how many bytes or which bytes were wrong, they didn't agree with the spec, there is no "a little bit" wrong when it comes to messages based on a spec, so those messages were just completely wrong, period. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Sat, 21 Feb 2026 15:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
