Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )
Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/4d907793_f7791750?usp=email : PS1, Line 8: > What is wrong? "The messages in the spec were different. […] It is not really important because this was never working and the rdr_to_pc_parameters is pointless because we ignore the set message anyway and never change any parameters, so it was basically "working fine" since the octsim was created despite being wrong, and we do not have any bug reports about weird cards that don't work either. This just aligns it with the spec, that's it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Sat, 21 Feb 2026 16:43:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
