pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42202?usp=email )

Change subject: bsc: TC_stat_msc_sctp_disconnected Fix sporadic failure
......................................................................

bsc: TC_stat_msc_sctp_disconnected Fix sporadic failure

Since we recently increased a bit the timeout to assume the BSSAP_LE
peer (SMLC) is implicitly up, the function
f_bssap_le_wait_sccp_peer_available() may still be onging when we drop
the sctp connection at the STP in the test, which will generate an
explicit DUNA towards BSSAP_LE and hence fail the test because it never
comes back available before it times out.

Since we don't need nor test SMLC in this test, simply disable starting
the SMLC here to avoid this race condition and simplify the test.

Change-Id: Ib063a481d9039cbcd462609404dbae14922c7510
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve




diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a9d063d..ef02faf 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -3269,7 +3269,7 @@
        var MSC_ConnHdlr vc_conn;
        var integer exp_total_num_msc;

-       f_init(nr_bts := 1, handler_mode := true, nr_msc := 1);
+       f_init(nr_bts := 1, handler_mode := true, nr_msc := 1, enable_smlc := 
false);
        if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_AoIP) {
                exp_total_num_msc := NUM_MSC;
                f_init_vty_stp();

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42202?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib063a481d9039cbcd462609404dbae14922c7510
Gerrit-Change-Number: 42202
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>

Reply via email to