Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 3: (5 comments) File CommonLibs/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/32d0c1e0_84eec133?usp=email : PS3, Line 56: lib_LTLIBRARIES = libcommon.la By doing this, you are installing the libraries, which is something we don't wanna do. File GSM/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/c6e2181f_a4fd25ed?usp=email : PS3, Line 29: gsm_headers = \ You are now also installing headers which shouldn't be installed afaiu. File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/cffc163a_9ac32661?usp=email : PS3, Line 82: AC_DISABLE_SHARED dnl don't build shared libraries (emscripten) I changed this, see my patchset in https://gerrit.osmocom.org/c/osmo-trx/+/42252/ https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/e94559b7_a07b4618?usp=email : PS3, Line 306: PKG_CHECK_MODULES(LIBUSB, libusb-1.0) See "https://gerrit.osmocom.org/c/osmo-trx/+/42255 Drop libusb dependency" https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/1382e3c6_37796f00?usp=email : PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f) fftw3.h is being included in Transceiver52M/arch/common/fft.c , and then fft.h is being included by: Transceiver52M/Channelizer.cpp 33:#include "fft.h" Transceiver52M/ChannelizerBase.cpp 34:#include "fft.h" Transceiver52M/ChannelizerBase.h 22: struct fft_hdl *fftHandle; Transceiver52M/Synthesis.cpp 34:#include "fft.h" How are you supposed to be building without all that? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 16:42:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
