Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 3: (3 comments) File GSM/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/defca419_5939a6ae?usp=email : PS3, Line 29: gsm_headers = \ > You are now also installing headers which shouldn't be installed afaiu. Understood. I’ll adjust that once we agree on the strategy for organizing a static library suitable for building `osmo-bts-trx` and `osmo-trx` together. File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/a480b099_18fee570?usp=email : PS3, Line 82: AC_DISABLE_SHARED dnl don't build shared libraries (emscripten) > I changed this, see my patchset in https://gerrit.osmocom. […] Sounds good. Once this is merged, I'll rebase my branch accordingly. https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/3414ccee_416d580e?usp=email : PS3, Line 306: PKG_CHECK_MODULES(LIBUSB, libusb-1.0) > See "https://gerrit.osmocom. […] Sounds good. Once this is merged, I'll rebase my branch accordingly. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 18:41:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
