Attention is currently required from: fixeria. csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42289?usp=email )
Change subject: nokia_site: Change the LAPD N200 counter for RSL ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: Thanks! Yours is a lot cleaner. Comment added as well. File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42289/comment/15f92719_31549961?usp=email : PS2, Line 120: if (link->sapi == SAPI_RSL) { : ts->lapd->profile.n200 = 20; : ts->lapd->profile.t200_sec = 1; : ts->lapd->profile.t200_usec = 0; : lapd_sap_start(ts->lapd, link->tei, : link->sapi); : } else { : ts->lapd->profile.t200_sec = 1; : ts->lapd->profile.t200_usec = 0; : lapd_sap_start(ts->lapd, link->tei, : link->sapi); : > I think you can reduce code duplication here a bit: […] Fix applied. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie4bb804ea636eba2182586db13a625c5933eff31 Gerrit-Change-Number: 42289 Gerrit-PatchSet: 4 Gerrit-Owner: csaba.sipos <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: domi <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 06 Mar 2026 19:41:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
