fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42290?usp=email )
Change subject: erab_fsm: fix comment inaccuracies and a typo
......................................................................
erab_fsm: fix comment inaccuracies and a typo
Two comments copy-pasted from session_establish were left saying
"ESTABLISH Req" in session_modify and session_delete handlers where
"MODIFY Req" and "DELETE Req" are correct respectively.
Also fix typo "unieue" -> "unique" in init/1.
Change-Id: If84638142988767363aa080012b44082dee39f90
---
M src/erab_fsm.erl
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw
refs/changes/90/42290/1
diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl
index f281e4b..1e39cb7 100644
--- a/src/erab_fsm.erl
+++ b/src/erab_fsm.erl
@@ -233,7 +233,7 @@
init([UID]) ->
set_logging_prefix(UID),
?LOG_DEBUG("Creating E-RAB FSM (UID ~p)", [UID]),
- %% request a unieue SEID for this E-RAB FSM
+ %% request a unique SEID for this E-RAB FSM
{ok, SEID} = pfcp_peer:seid_alloc(),
{ok, erab_wait_setup_req,
#erab_state{uid = UID,
@@ -360,7 +360,7 @@
{reply, From, {error, {timeout, ?FUNCTION_NAME}}}};
session_modify(info, #pfcp{type = session_modification_response,
- seid = SEID_Rsp, %% matches F-SEID we sent in the
ESTABLISH Req
+ seid = SEID_Rsp, %% matches F-SEID we sent in the
MODIFY Req
ie = #{pfcp_cause := 'Request accepted'}},
#erab_state{mod_kind = ModKind,
from = From,
@@ -504,7 +504,7 @@
rel_kind = RelKind} = S) ->
case PDU of
#pfcp{type = session_deletion_response,
- seid = SEID_Rsp, %% matches F-SEID we sent in the ESTABLISH Req
+ seid = SEID_Rsp, %% matches F-SEID we sent in the DELETE Req
ie = #{pfcp_cause := 'Request accepted'}} ->
?LOG_DEBUG("PFCP session deleted"),
case RelKind of
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: If84638142988767363aa080012b44082dee39f90
Gerrit-Change-Number: 42290
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
