Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42274?usp=email )
Change subject: esim/http_json_api: allow URL rewriting ...................................................................... Patch Set 1: (1 comment) File pySim/esim/http_json_api.py: https://gerrit.osmocom.org/c/pysim/+/42274/comment/3509898e_31a05743?usp=email : PS1, Line 339: -> (dict, str): This is not a valid type spec. for a tuple. It should be: ```suggestion def rewrite_url(self, data: dict, url: str) -> tuple[dict, str]: ``` or `Tuple[dict, str]`, in case we care about EOL Python versions <3.9. It might be a good idea to do more type checking using pylint (or mypy) during the build verification for Python projects in Jenkins. It could be a separate job just posting comments and printing the resulting code quality score, but not failing the build (V-1). @[email protected], @[email protected] what do you think? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id2713a867079cc140517fe312189e5e2162608a5 Gerrit-Change-Number: 42274 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Sat, 07 Mar 2026 14:32:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
