Attention is currently required from: fixeria, laforge, neels. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42274?usp=email )
Change subject: esim/http_json_api: allow URL rewriting ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/42274/comment/bc1b3125_cf12f0a0?usp=email : PS1, Line 15: reqrite_url > (typo) Done File pySim/esim/http_json_api.py: https://gerrit.osmocom.org/c/pysim/+/42274/comment/c121aab3_6f575351?usp=email : PS1, Line 373: reqriting > (typo) Done https://gerrit.osmocom.org/c/pysim/+/42274/comment/759bb415_adf8ef87?usp=email : PS1, Line 391: data > maybe it would be good to complete composition of data before calling > rewrite_url()? i mean, maybe r […] We can move it below the line. I see no problems with that. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id2713a867079cc140517fe312189e5e2162608a5 Gerrit-Change-Number: 42274 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2026 14:13:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]>
